Skip to content

Fix: Remove expected error message #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

iluuu1994 merged 1 commit into phpstan:master from localheinz:fix/build

Dec 5, 2018

Merged

Fix: Remove expected error message #3

iluuu1994 merged 1 commit into phpstan:master from localheinz:fix/build

Dec 5, 2018

Conversation

Copy link

Contributor

@localheinz localheinz commented Dec 5, 2018

This PR

fixes the build by removing an expected error message

Follows 1ed86a5.

💁‍♂️ Not sure if instead the CallToDeprecatedStaticMethodRule should be fixed. What do you think?


 Fix: Remove expected error message

b8d27c8

localheinz commented

View reviewed changes

tests/Rules/Deprecations/CallToDeprecatedStaticMethodRuleTest.php

13,

],

[

'Call to deprecated method deprecatedFoo() of class CheckDeprecatedStaticMethodCall\Foo.',

Copy link

Contributor Author

@localheinz localheinz Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of

phpstan-deprecation-rules/src/Rules/Deprecations/CallToDeprecatedStaticMethodRule.php

Lines 43 to 45 in 1ed86a5

if (DeprecatedScopeHelper::isScopeDeprecated($scope)) {

return [];

}

and

phpstan-deprecation-rules/tests/Rules/Deprecations/data/call-to-deprecated-static-method-definition.php

Lines 13 to 19 in 1ed86a5

/**

* @deprecated

*/

public static function deprecatedFoo()

{

}

and

phpstan-deprecation-rules/tests/Rules/Deprecations/data/call-to-deprecated-static-method.php

Lines 18 to 22 in 1ed86a5

public static function deprecatedFoo()

{

parent::foo();

parent::deprecatedFoo();

}

we never enter the scope of the deprecated method Bar::deprecatedFoo().

@iluuu1994 iluuu1994 merged commit cc60143 into phpstan:master

Copy link

Collaborator

iluuu1994 commented Dec 5, 2018

Ah, I didn't realize deprecatedFoo() was overwritten. Since 0.11 phpDoc annotations are implicitly inherited. Since the method itself is now deprecated the error message goes away. I think this is ok.

@ondrejmirtes Do you agree?

Copy link

Collaborator

iluuu1994 commented Dec 5, 2018

Thanks 🙂

@localheinz localheinz deleted the fix/build branch

December 5, 2018 17:14

Copy link

Contributor Author

localheinz commented Dec 5, 2018

Thank you, @iluuu1994!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment